GH-48055: [C++][FlightRPC] Allow spaces while parsing Table Type in ODBC#48056
Merged
Conversation
alinaliBQ
changed the title
|
|
justing-bq
reviewed
Nov 5, 2025
github-actions
Bot
added
awaiting committer review
Co-authored-by: justing-bq <justin.gossett@improving.com>
alinaliBQ
force-pushed
the
gh-48055-allow-space
branch
from
9d8b535 to
a6b3cd0
Compare
lidavidm
approved these changes
Nov 6, 2025
|
|
||
| // Only put the string if the trimmed result is non-empty | ||
| if (!trimmed_type.empty()) { | ||
| table_types.emplace_back(trimmed_type); |
Member
There was a problem hiding this comment.
Seems reasonable but is there maybe a way to do this with string_view instead of copying the string?
Member
There was a problem hiding this comment.
I suppose it's not likely to matter
Contributor
There was a problem hiding this comment.
A string copy is still necessary for the sake of trimming the string.
github-actions
Bot
added
awaiting merge
github-actions
Bot
added
awaiting change review
Contributor
|
@lidavidm Please take another look. |
lidavidm
approved these changes
Nov 9, 2025
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 4576192. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…e in ODBC (apache#48056) ### Rationale for this change Allow spaces while parsing Table Type in ODBC. For example, driver should be able to interpret `" TABLE , VIEW "` as "TABLE" and "VIEW". ### What changes are included in this PR? - Allow spaces while parsing Table Type in ODBC & Add 3 tests ### Are these changes tested? Tested locally on Windows MSVC. ### Are there any user-facing changes? N/A * GitHub Issue: apache#48055 Lead-authored-by: Alina (Xi) Li <alina.li@improving.com> Co-authored-by: justing-bq <62349012+justing-bq@users.noreply.github.com> Co-authored-by: justing-bq <justin.gossett@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Allow spaces while parsing Table Type in ODBC. For example, driver should be able to interpret
" TABLE , VIEW "as "TABLE" and "VIEW".What changes are included in this PR?
Are these changes tested?
Tested locally on Windows MSVC.
Are there any user-facing changes?
N/A